-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] Add Cookies and Surface with Privacy Notices #3572
Conversation
…and System and an upsert_cookies method that is called when creating/updating privacy declarations.
…pdate cookies as well as insert/delete.
…s this can't be specified on the system directly currently. - Fix bug where path/domain aren't being saved on create. - Add system endpoints to postman collection with new cookie fields. - Add database annotations.
Passing run #2867 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Conflicts: src/fides/api/ctl/database/crud.py src/fides/api/ctl/database/system.py src/fides/api/ctl/migrations/versions/5307999c0dac_remove_deprecated_data_uses_for_.py src/fides/api/ctl/schemas/system.py src/fides/api/ctl/sql_models.py src/fides/api/models/privacy_notice.py tests/conftest.py tests/ctl/core/test_system.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looking good! going to start integrating with the frontend, will report back!
# Conflicts: # src/fides/api/api/v1/endpoints/connection_endpoints.py
src/fides/api/api/v1/endpoints/dataset_endpoints.py src/fides/api/models/datasetconfig.py src/fides/api/util/data_category.py
…g has been fixed.
…e in the correct order.
@pattisdr it looks like the fideslang issues are fixed! The final database URL failure is probably related to a |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3572 +/- ##
==========================================
+ Coverage 87.06% 87.10% +0.03%
==========================================
Files 310 310
Lines 18996 19031 +35
Branches 2432 2437 +5
==========================================
+ Hits 16539 16577 +38
+ Misses 2028 2026 -2
+ Partials 429 428 -1
☔ View full report in Codecov by Sentry. |
@pattisdr the docs failure here is expected, it'll fail because the The other Pytest failure is weird to me...I think you recently wrote that so maybe you can confirm if it is intermittent? The mypy thing is new it seems |
@ThomasLaPiana this mypy issue we've been running into across all our branches - isort will move that ignore down a line, so it's no longer ignoring the correct line for mypy. What fixes it for one check will break it for the other
It is intermittent but I need to dig into it more. I worry there's something I don't understand about async sessions. I haven't seen it failing on 3.8 or 9 but 3.10 EDIT: Maybe it has to do with system.privacy_declarations order being inconsistent? |
src/fides/api/api/v1/endpoints/dataset_endpoints.py src/fides/api/models/datasetconfig.py src/fides/api/util/data_category.py tests/ctl/core/test_system.py tests/ops/api/v1/endpoints/test_dataset_endpoints.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍪
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
- Backend: Add a Cookies table with FK's to PrivacyDeclaration and System. Surface cookies on privacy notices, calculated at runtime - Frontend: Add cookie input field on system data use tab - Frontend: Have `fides-js` and privacy center delete cookies associated with notices that were opted out of Co-authored-by: Thomas <thomas.lapiana+github@pm.me> Co-authored-by: Thomas <ThomasLaPiana@users.noreply.github.com> Co-authored-by: Allison King <allison@ethyca.com>
Closes #3477
❗ Dependent on Fideslang release https://github.com/ethyca/fideslang/pull/115
❗ Contains migration; check downrev before merge
Description Of Changes
As a privacy admin, I want to document the cookies utilized by a system to deliver its services and functionalities, so that they can be mapped to privacy notices and operated on by the privacy experiences for consent related opt-in/out and so that I have a record of cookies for compliance purposes.
Code Changes
Cookies
table with a FK to bothprivacy_declaration
andsystem
, in case the privacy declaration gets deleted, we still have cookies that are unassociated with a specific data use and still connected to the system.privacy_declarations
when creating/updating systems via the APIupsert_cookies
method that is called when privacy declarations are created/updatedSteps to Confirm
POST {{host}}/system
Pre-Merge Checklist
CHANGELOG.md